Index pattern on the filters of home KPI links #6777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Details 🟢 With an index pattern with the same title and ID, go to Home > Overview, the KPI links should display and redirect correctly to the Discover app and the filters should be applied without errorsChrome - 🟢
🟢 With an index pattern with a different title and ID, go to Home > Overview, the KPI links should display and redirect correctly to the Discover app and the filters should be applied without errorsChrome - 🟢
|
jbiset
reviewed
Jun 19, 2024
jbiset
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
CR: 🟢
Test UI 🟢
Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
UI
| Test | Chrome | Firefox | Safari |
|---|---|---|---|
| With an index pattern with the same title and ID, go to Home > Overview, the KPI links should display and redirect correctly to the Discover app and the filters should be applied without errors | 🟢 | 🟢 | ⚫ |
| With an index pattern with a different title and ID, go to Home > Overview, the KPI links should display and redirect correctly to the Discover app and the filters should be applied without errors | 🟢 | 🟢 | ⚫ |
Details
🟢 With an index pattern with the same title and ID, go to Home > Overview, the KPI links should display and redirect correctly to the Discover app and the filters should be applied without errors
Chrome - 🟢
Firefox - 🟢
Safari - ⚫
🟢 With an index pattern with a different title and ID, go to Home > Overview, the KPI links should display and redirect correctly to the Discover app and the filters should be applied without errors
Chrome - 🟢
Firefox - 🟢
Safari - ⚫
TestLegend: UI
Details 🟢 With an index pattern with the same title and ID, go to Home > Overview, the KPI links should display and redirect correctly to the Discover app and the filters should be applied without errorsChrome - 🟢 
Firefox - ⚫ Safari - ⚫ 🟢 With an index pattern with a different title and ID, go to Home > Overview, the KPI links should display and redirect correctly to the Discover app and the filters should be applied without errorsChrome - 🟢 
Firefox - ⚫ Safari - ⚫ |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes the hardcoded value of index pattern on the filters of home KPI links.
Side changes:
Issues Resolved
#6776
Evidence
Test
Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
UI
Details
⚫ With an index pattern with the same title and ID, go to Home > Overview, the KPI links should display and redirect correctly to the Discover app and the filters should be applied without errors
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ With an index pattern with a different title and ID, go to Home > Overview, the KPI links should display and redirect correctly to the Discover app and the filters should be applied without errors
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
Check List
yarn test:jest